Generalize the type interface to tensor.zeros #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
previously approved these changes
Aug 24, 2020
brandonwillard
force-pushed
the
generalize-zeros-interface
branch
from
202e6d2
to
a3f700d
Compare
brandonwillard
force-pushed
the
generalize-zeros-interface
branch
from
de84872
to
8d90c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows all sequence/array types as arguments to
tt.zerosandtt.ones. For example, with these changes one can now pass NumPy arrays as the shape argument to both functions, and prevents reasonable expectations like this from raising cryptic exceptions.