Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TopKOp and related functionality #377

Closed
ricardoV94 opened this issue Jul 13, 2023 · 1 comment · Fixed by #686
Closed

Remove TopKOp and related functionality #377

ricardoV94 opened this issue Jul 13, 2023 · 1 comment · Fixed by #686
Labels
beginner friendly maintenance

Comments

@ricardoV94
Copy link
Member

This Op seems pretty esoteric and does not correspond to any Numpy core functionality.

For the sake of reducing maintenance burden I suggest we remove it.

pytensor/pytensor/tensor/sort.py

Line 309 in 7218431

class TopKOp(Op):

@ricardoV94 ricardoV94 changed the title Consider removing TopKOp and related functionality Remove TopKOp and related functionality Dec 6, 2023
@ricardoV94 ricardoV94 mentioned this issue Dec 6, 2023
Closed
@mory91 mory91 mentioned this issue Mar 30, 2024
Merged
10 tasks
@mory91
Copy link
Contributor

mory91 commented Mar 30, 2024

Tried in #686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TopkOp mory91/pytensor
2 participants
@mory91 @ricardoV94