Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug: jax tests reference jax.interpreters.xla.DeviceArray #660

Open
leventov opened this issue Mar 7, 2024 · 2 comments
Open

minor bug: jax tests reference jax.interpreters.xla.DeviceArray #660

leventov opened this issue Mar 7, 2024 · 2 comments
Labels

Comments

@leventov
Copy link

leventov commented Mar 7, 2024

Describe the issue:

#133 In this PR, the second branch of this conditional:

if must_be_device_array:
if isinstance(jax_res, list):
assert all(isinstance(res, jax.Array) for res in jax_res)
else:
assert isinstance(jax_res, jax.interpreters.xla.DeviceArray)

was evidently not updated only because it is never executed in the tests.

cc @ricardoV94

Reproducable code example:

n/a

Error message:

No response

PyTensor version information:

n/a

Context for the issue:

No response

@leventov leventov added the bug Something isn't working label Mar 7, 2024
@ricardoV94
Copy link
Member

@leventov want to update it?

@leventov
Copy link
Author

leventov commented Mar 8, 2024

Yes, I can do it later.

Also: probably this function as well as compare_numba_and_py() should use itertools.zip_longest rather than zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants