Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Detect clang++ as a g++ alternative on Linux #762

Open
mark-thm opened this issue May 11, 2024 · 2 comments
Open

ENH: Detect clang++ as a g++ alternative on Linux #762

mark-thm opened this issue May 11, 2024 · 2 comments

Comments

@mark-thm
Copy link
Contributor

mark-thm commented May 11, 2024

Before

pytensor will only attempt to use g++ as a C++ compiler when running on Linux.

After

Improve pytensor by:

  1. If the CXX environment variable is set, use the value to determine the C++ compiler
  2. Discover g++ or clang++ on any platform

Context for the issue:

Today, pytensor will only discover g++ on Linux even though it can/will use clang++ on MacOS.

I'd be willing to propose a change here but wanted to gauge maintainer interest, first.

@maresb
Copy link
Contributor

maresb commented May 11, 2024

From my perspective this sounds great!

One challenge I see is that we're not running tests osx so we don't currently have test coverage for clang. There seem to be some bugs that should be fixed in any case. See for example #136.

@ricardoV94
Copy link
Member

ricardoV94 commented May 13, 2024

Can you set the clang path in pytensor.config.cxx and it just works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants