Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run mypy in pre-commit #768

Closed
ricardoV94 opened this issue May 14, 2024 · 2 comments · Fixed by #775
Closed

Don't run mypy in pre-commit #768

ricardoV94 opened this issue May 14, 2024 · 2 comments · Fixed by #775
Labels

Comments

@ricardoV94
Copy link
Member

Description

It's too slow, let it run in the CI

@HangenYuu
Copy link
Contributor

HangenYuu commented May 18, 2024

As I read the documentation,

  1. There are tag skip for hook to be skipped in CI, but no tag for hook to be run only in CI.
  2. There is tag stages to confine hook to a certain stage only.

The way I look at it, you want pre-commit run as a GitHub Action only and not locally? Then it can be done by removing mypy from the pre-commit config file and add the pre-commit GitHub Action as a step in .github/workflows/test.yml. If it's okay then I can create a PR for it quickly.

@ricardoV94
Copy link
Member Author

You can probably use the pymc as a template: https://github.com/pymc-devs/pymc/blob/main/.github%2Fworkflows%2Fmypy.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants