Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should unit tests live outside of the package? #79

Closed
lucianopaz opened this issue Nov 17, 2022 · 3 comments · Fixed by #116
Closed

Should unit tests live outside of the package? #79

lucianopaz opened this issue Nov 17, 2022 · 3 comments · Fixed by #116
Assignees

Comments

@lucianopaz
Copy link
Contributor

We are shipping our the tests folder inside of the pymmmc package. I don't think is is necessary or desirable. I propose that we move the tests folder to the root directory instead.

Current organization:
root/
└─> pymmmc/
└─> tests/

Proposed:
root/
├─> pymmmc/
└─> tests/

@ricardoV94
Copy link
Contributor

No objections

@drbenvincent
Copy link
Contributor

Agree. I believe this means that the tests are not packaged up into the pypi build, which is good.

Probably want a clear split (with folders?) between mmm and clv tests.

@ricardoV94
Copy link
Contributor

Closed by #116 (there was a typo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants