Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor message format for Channels #63

Open
BenediktBurger opened this issue Oct 31, 2023 · 0 comments
Open

Actor message format for Channels #63

BenediktBurger opened this issue Oct 31, 2023 · 0 comments
Labels
discussion-needed A solution still needs to be determined messages Concerns the message format

Comments

@BenediktBurger
Copy link
Member

BenediktBurger commented Oct 31, 2023

In pymeasure/pyleco#14 I noticed that we currently have not yet (in PR #56) defined, how to access a channel of a controlled device. (related to #20 , #29 )

I see the following options for the get/set_parameters and call_action methods:

  1. They offer a keyword argument "channel" to choose a subchannel. Advantage: It is more simple to implement a check for locked Channels.
  2. If a period is encountered in the action/parameter name, the Actor tries to follow that "instance path" (e.g. "channel_1.trace_A.property_X" will be resolved to the property_X of trace_A of channel_1 of the device).
  3. We have special methods call_action_channel...

My favorite is option 2, as that allows subchannels etc. seamlessly.

@BenediktBurger BenediktBurger added discussion-needed A solution still needs to be determined messages Concerns the message format labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-needed A solution still needs to be determined messages Concerns the message format
Projects
None yet
Development

No branches or pull requests

1 participant