Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPCGenerator depends on private API #5

Closed
BenediktBurger opened this issue Jul 10, 2023 · 1 comment · Fixed by #63
Closed

RPCGenerator depends on private API #5

BenediktBurger opened this issue Jul 10, 2023 · 1 comment · Fixed by #63

Comments

@BenediktBurger
Copy link
Member

The RPCGenerator in #3 depends on the private API of jsonrpc2-pyclient, as the baseclass is intended to include some message transfer methods, which are incompatible with pyleco.

@bilderbuchi
Copy link
Member

bilderbuchi commented Jul 11, 2023

The private API is from jsonrpc2pyclient._irpcclient import IRPCClient, which we inherit from.

Maybe useful: In what way are these message transfer methods incompatible?

When the dust has settled, it might be worth it to inquire about this upstream, maybe this points to a design change on their end, or there is a better way to achieve what we need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants