Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Adapter communication methods #512

Closed
bilderbuchi opened this issue Nov 5, 2021 · 0 comments · Fixed by #660
Closed

Restructure Adapter communication methods #512

bilderbuchi opened this issue Nov 5, 2021 · 0 comments · Fixed by #660

Comments

@bilderbuchi
Copy link
Member

If we restructured Adapter and subclasses so that we can put common functionality into Adapter, that delegates to subclasses' specific implementations, we could gain several useful features without duplicating across all adapters:

InstrumentKit uses an approach where in the base class there are concrete methods that delegate to abstract methods that are overridden by subclasses.
The concrete methods can have common functionality (like logging) in one place, so they can observe DRY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant