Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spanish subtitle providers #7505

Closed
porzino opened this issue Dec 17, 2019 · 16 comments
Closed

Add spanish subtitle providers #7505

porzino opened this issue Dec 17, 2019 · 16 comments
Labels
triage Untriaged issue

Comments

@porzino
Copy link
Contributor

porzino commented Dec 17, 2019

Hi.
Today I have installed medusa on synology NAS for the first time.
Until now, I had installed sickrage, but yesterday it stopped working.
I made in sickrage two subtitle providers for spanish that worked.
Is it possible to add them in medusa?

@triage-new-issues triage-new-issues bot added the triage Untriaged issue label Dec 17, 2019
@p0psicles
Copy link
Contributor

We use subliminal. You'll have to add them there

@porzino
Copy link
Contributor Author

porzino commented Dec 17, 2019

Yes, I know.
In sickrage you could add an external script to subliminal and register it to be available in sickrage.
Now, is this not possible?
Because I have seen that itasa and weizdom have been added in medusa as external providers.
I have the code to support these two spanish providers.
Can't do the same as with itasa?

@medariox
Copy link
Contributor

Yes, you can add any code you want, but we won't provide support obviously.

@porzino
Copy link
Contributor Author

porzino commented Dec 17, 2019

Yes I know it.
I don't speak english well and maybe I can't explain myself well.
My question is, in the same way that support has been added to italian subs and wizdom subs, can I give you the code to add support to tusubtitulo.com and subtitulamos.tv?

@medariox
Copy link
Contributor

It would be better to have it added to subliminal, but I understand things are pretty stale over there. If you submit a PR and the code is alright we can add them as external providers, yes.

@porzino
Copy link
Contributor Author

porzino commented Dec 17, 2019

OK, that's perfect because subliminal seems stopped.

Now my question is that I don't see where I can tell Medusa that there are two more providers.
I found in the subtitles.py file a constant called "PROVIDER_URLS" and I added the new providers, but I can't seen them in the web.
I have also added the images in the folder.
Where can I ask for someone to help me only in this point?

Then I will adapt the providers code so they work correctly.
I have experience in other languages, but not in python.

@porzino
Copy link
Contributor Author

porzino commented Dec 17, 2019

Oh, here is my PR in subliminal, but it was not added to the project:
Diaoul/subliminal#826

@medariox
Copy link
Contributor

medariox commented Dec 17, 2019

See what was done to add Wizdom for example: b02bc07#diff-804c30038c5fab77b8fa014b77712099

@porzino
Copy link
Contributor Author

porzino commented Dec 17, 2019

Thanks a lot.
That was a great help.
Finally both providers are listed in the page.
Now, I'm going to test them and fix them.

@porzino
Copy link
Contributor Author

porzino commented Dec 18, 2019

Hi again.
The two subtitle providers are working fine.
How can I submit the code to add them as external providers?

@p0psicles
Copy link
Contributor

Create a pull request against develop branch

@elbeborandy
Copy link

Hello. I'm the admin of TuSubtitulo.com(RGarciaPR) and none of you have contacted us to ask for permission to add our site on this script.

We kindly ask to stop this development because we've not gave permission to this.

Otherwise, we'll contact Github to disable
this repo.

If you have any question, contact us at info@tusubtitulo.com

@porzino
Copy link
Contributor Author

porzino commented Dec 19, 2019

E-mail send it to info@tusubtitulo.com

@porzino
Copy link
Contributor Author

porzino commented Dec 19, 2019

Hi again,

I have permission from subtitulamos.tv to include the script.
I'm waiting answer from info@tusubtitulo.com.

@porzino
Copy link
Contributor Author

porzino commented Dec 21, 2019

I have created a PR to add support to subtitulamos.tv.
The PR is #7518
I don't know if I have done well. It's the second time I use github.

tusubtitulo.com has not given permission, so for now I don't add support.

@medariox
Copy link
Contributor

medariox commented Jan 6, 2020

subtitulamos.tv has been added and will be available with next version.

@medariox medariox closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Untriaged issue
Projects
None yet
Development

No branches or pull requests

4 participants