Fix using len() to see if something is empty

sickbeard/clients/deluge_client.py

@@ -66,7 +66,7 @@ def _get_auth(self):
                 return None
 
             hosts = self.response.json()['result']
-            if len(hosts) == 0:
+            if not hosts:
                 logger.log(self.name + u': WebUI does not contain daemons', logger.ERROR)
                 return None
 

sickbeard/dailysearcher.py

@@ -98,7 +98,7 @@ def run(self, force=False):  # pylint:disable=too-many-branches
 
                 sql_l.append(ep.get_sql())
 
-        if len(sql_l) > 0:
+        if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
         else:

sickbeard/failed_history.py

@@ -54,29 +54,28 @@ def logFailed(release):
     failed_db_con = db.DBConnection('failed.db')
     sql_results = failed_db_con.select("SELECT * FROM history WHERE release=?", [release])
 
-    if len(sql_results) == 0:
-        logger.log(
-            u"Release not found in snatch history.", logger.WARNING)
-    elif len(sql_results) > 1:
+    if not sql_results:
+        logger.log(u"Release not found in snatch history.", logger.WARNING)
+    elif len(sql_results) == 1:
+        size = sql_results[0]["size"]
+        provider = sql_results[0]["provider"]
+    else:
         logger.log(u"Multiple logged snatches found for release", logger.WARNING)
         sizes = len(set(x["size"] for x in sql_results))
         providers = len(set(x["provider"] for x in sql_results))
         if sizes == 1:
-            logger.log(u"However, they're all the same size. Continuing with found size.", logger.WARNING)
+            logger.log(u"However, they're all the same size. "
+                       u"Continuing with found size.", logger.WARNING)
             size = sql_results[0]["size"]
         else:
-            logger.log(
-                u"They also vary in size. Deleting the logged snatches and recording this release with no size/provider",
-                logger.WARNING)
+            logger.log(u"They also vary in size. Deleting the logged snatches and "
+                       u"recording this release with no size/provider", logger.WARNING)
             for result in sql_results:
                 deleteLoggedSnatch(result["release"], result["size"], result["provider"])
 
         if providers == 1:
             logger.log(u"They're also from the same provider. Using it as well.")
             provider = sql_results[0]["provider"]
-    else:
-        size = sql_results[0]["size"]
-        provider = sql_results[0]["provider"]
 
     if not hasFailed(release, size, provider):
         failed_db_con = db.DBConnection('failed.db')

sickbeard/generic_queue.py

@@ -82,7 +82,7 @@ def run(self, force=False):
                     self.currentItem = None
 
                 # if there's something in the queue then run it in a thread and take it out of the queue
-                if len(self.queue) > 0:
+                if self.queue:
 
                     # sort by priority
                     def sorter(x, y):

sickbeard/helpers.py

@@ -83,7 +83,7 @@ def indentXML(elem, level=0):
     Does our pretty printing, makes Matt very happy
     """
     i = "\n" + level * "  "
-    if len(elem):
+    if elem:
         if not elem.text or not elem.text.strip():
             elem.text = i + "  "
         if not elem.tail or not elem.tail.strip():
@@ -738,7 +738,7 @@ def get_all_episodes_from_absolute_number(show, absolute_numbers, indexer_id=Non
     episodes = []
     season = None
 
-    if len(absolute_numbers):
+    if absolute_numbers:
         if not show and indexer_id:
             show = Show.find(sickbeard.showList, indexer_id)
 
@@ -1340,7 +1340,7 @@ def mapIndexersToShow(showObj):
                     "INSERT OR IGNORE INTO indexer_mapping (indexer_id, indexer, mindexer_id, mindexer) VALUES (?,?,?,?)",
                     [showObj.indexerid, showObj.indexer, int(mapped_show[0]['id']), indexer]])
 
-        if len(sql_l) > 0:
+        if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 

sickbeard/metadata/generic.py

@@ -578,7 +578,7 @@ def save_season_posters(self, show_obj, season):
 
             cur_season_art = season_dict[cur_season]
 
-            if len(cur_season_art) == 0:
+            if not cur_season_art:
                 continue
 
             # Just grab whatever's there for now
@@ -625,7 +625,7 @@ def save_season_banners(self, show_obj, season):
 
             cur_season_art = season_dict[cur_season]
 
-            if len(cur_season_art) == 0:
+            if not cur_season_art:
                 continue
 
             # Just grab whatever's there for now

sickbeard/notifiers/emailnotify.py

@@ -67,7 +67,7 @@ def notify_snatch(self, ep_name, title='Snatched:'):  # pylint: disable=unused-a
         if sickbeard.USE_EMAIL and sickbeard.EMAIL_NOTIFY_ONSNATCH:
             show = self._parseEp(ep_name)
             to = self._generate_recipients(show)
-            if len(to) == 0:
+            if not to:
                 logger.log('Skipping email notify because there are no configured recipients', logger.DEBUG)
             else:
                 try:
@@ -113,7 +113,7 @@ def notify_download(self, ep_name, title='Completed:'):  # pylint: disable=unuse
         if sickbeard.USE_EMAIL and sickbeard.EMAIL_NOTIFY_ONDOWNLOAD:
             show = self._parseEp(ep_name)
             to = self._generate_recipients(show)
-            if len(to) == 0:
+            if not to:
                 logger.log('Skipping email notify because there are no configured recipients', logger.DEBUG)
             else:
                 try:
@@ -159,7 +159,7 @@ def notify_subtitle_download(self, ep_name, lang, title='Downloaded subtitle:'):
         if sickbeard.USE_EMAIL and sickbeard.EMAIL_NOTIFY_ONSUBTITLEDOWNLOAD:
             show = self._parseEp(ep_name)
             to = self._generate_recipients(show)
-            if len(to) == 0:
+            if not to:
                 logger.log('Skipping email notify because there are no configured recipients', logger.DEBUG)
             else:
                 try:
@@ -199,7 +199,7 @@ def notify_git_update(self, new_version='??'):
         '''
         if sickbeard.USE_EMAIL:
             to = self._generate_recipients(None)
-            if len(to) == 0:
+            if not to:
                 logger.log('Skipping email notify because there are no configured recipients', logger.DEBUG)
             else:
                 try:
@@ -236,7 +236,7 @@ def notify_login(self, ipaddress=''):
         '''
         if sickbeard.USE_EMAIL:
             to = self._generate_recipients(None)
-            if not len(to):
+            if not to:
                 logger.log('Skipping email notify because there are no configured recipients', logger.DEBUG)
             else:
                 try:
@@ -274,7 +274,7 @@ def _generate_recipients(show):  # pylint: disable=too-many-branches
         # Grab the global recipients
         if sickbeard.EMAIL_LIST:
             for addr in sickbeard.EMAIL_LIST.split(','):
-                if len(addr.strip()) > 0:
+                if addr.strip():
                     addrs.append(addr)
 
         # Grab the per-show-notification recipients
@@ -285,11 +285,11 @@ def _generate_recipients(show):  # pylint: disable=too-many-branches
                         if subs[b'notify_list'][0] == '{':
                             entries = dict(ast.literal_eval(subs[b'notify_list']))
                             for addr in entries[b'emails'].split(','):
-                                if len(addr.strip()) > 0:
+                                if addr.strip():
                                     addrs.append(addr)
                         else:                                           # Legacy
                             for addr in subs[b'notify_list'].split(','):
-                                if len(addr.strip()) > 0:
+                                if addr.strip():
                                     addrs.append(addr)
 
         addrs = set(addrs)

sickbeard/notifiers/prowl.py

@@ -49,7 +49,7 @@ def notify_snatch(self, ep_name):
         if sickbeard.PROWL_NOTIFY_ONSNATCH:
             show = self._parse_episode(ep_name)
             recipients = self._generate_recipients(show)
-            if len(recipients) == 0:
+            if not recipients:
                 logger.log('Skipping prowl notify because there are no configured recipients', logger.DEBUG)
             else:
                 for api in recipients:
@@ -61,7 +61,7 @@ def notify_download(self, ep_name):
         if sickbeard.PROWL_NOTIFY_ONDOWNLOAD:
             show = self._parse_episode(ep_name)
             recipients = self._generate_recipients(show)
-            if len(recipients) == 0:
+            if not recipients:
                 logger.log('Skipping prowl notify because there are no configured recipients', logger.DEBUG)
             else:
                 for api in recipients:
@@ -73,7 +73,7 @@ def notify_subtitle_download(self, ep_name, lang):
         if sickbeard.PROWL_NOTIFY_ONSUBTITLEDOWNLOAD:
             show = self._parse_episode(ep_name)
             recipients = self._generate_recipients(show)
-            if len(recipients) == 0:
+            if not recipients:
                 logger.log('Skipping prowl notify because there are no configured recipients', logger.DEBUG)
             else:
                 for api in recipients:
@@ -102,7 +102,7 @@ def _generate_recipients(show=None):
         # Grab the global recipient(s)
         if sickbeard.PROWL_API:
             for api in sickbeard.PROWL_API.split(','):
-                if len(api.strip()) > 0:
+                if api.strip():
                     apis.append(api)
 
         # Grab the per-show-notification recipients
@@ -113,7 +113,7 @@ def _generate_recipients(show=None):
                         if subs['notify_list'][0] == '{':               # legacy format handling
                             entries = dict(ast.literal_eval(subs['notify_list']))
                             for api in entries['prowlAPIs'].split(','):
-                                if len(api.strip()) > 0:
+                                if api.strip():
                                     apis.append(api)
 
         apis = set(apis)
@@ -127,7 +127,7 @@ def _send_prowl(prowl_api=None, prowl_priority=None, event=None, message=None, f
 
         if prowl_api is None:
             prowl_api = sickbeard.PROWL_API
-            if len(prowl_api) == 0:
+            if not prowl_api:
                 return False
 
         if prowl_priority is None:

sickbeard/numdict.py

@@ -29,7 +29,7 @@ def __init__(self, iterable=None, **kwargs):
         iterable = kwargs.pop('dict', None) if iterable is None else iterable
         if iterable is not None:
             self.update(iterable)
-        if len(kwargs):
+        if kwargs:
             self.update(kwargs)
 
     def __len__(self):

sickbeard/nzbSplitter.py

@@ -188,7 +188,7 @@ def split_result(obj):
             logger.log(u"Found " + new_nzb + " inside " + obj.name + " but it doesn't seem to belong to the same season, ignoring it",
                        logger.WARNING)
             continue
-        elif len(parsed_obj.episode_numbers) == 0:
+        elif not parsed_obj.episode_numbers:
             # pylint: disable=no-member
             logger.log(u"Found " + new_nzb + " inside " + obj.name + " but it doesn't seem to be a valid episode NZB, ignoring it",
                        logger.WARNING)

sickbeard/postProcessor.py

@@ -501,7 +501,7 @@ def _history_lookup(self):
             search_name = re.sub(r"[\.\- ]", "_", curName)
             sql_results = main_db_con.select("SELECT showid, season, quality, version, resource FROM history WHERE resource LIKE ? AND (action % 100 = 4 OR action % 100 = 6)", [search_name])
 
-            if len(sql_results) == 0:
+            if not sql_results:
                 continue
 
             indexer_id = int(sql_results[0]["showid"])
@@ -1166,7 +1166,7 @@ def process(self):  # pylint: disable=too-many-return-statements, too-many-local
                     cur_ep.download_subtitles(force=True)
 
         # now that processing has finished, we can put the info in the DB. If we do it earlier, then when processing fails, it won't try again.
-        if len(sql_l) > 0:
+        if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 
@@ -1177,7 +1177,7 @@ def process(self):  # pylint: disable=too-many-return-statements, too-many-local
                 cur_ep.location = ek(os.path.join, dest_path, new_file_name)
                 sql_l.append(cur_ep.get_sql())
 
-        if len(sql_l) > 0:
+        if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 

sickbeard/properFinder.py

@@ -323,7 +323,7 @@ def _set_lastProperSearch(when):
         main_db_con = db.DBConnection()
         sql_results = main_db_con.select("SELECT last_proper_search FROM info")
 
-        if len(sql_results) == 0:
+        if not sql_results:
             main_db_con.action("INSERT INTO info (last_backlog, last_indexer, last_proper_search) VALUES (?,?,?)",
                                [0, 0, str(when)])
         else:

sickbeard/providers/binsearch.py

@@ -113,7 +113,7 @@ def updateCache(self):
                 if ci:
                     cl.append(ci)
 
-        if len(cl) > 0:
+        if cl:
             cache_db_con = self._getDB()
             cache_db_con.mass_action(cl)
 

sickbeard/providers/freshontv.py

@@ -138,7 +138,7 @@ def search(self, search_params, age=0, ep_obj=None):  # pylint: disable=too-many
                         else:
                             page_links = []
 
-                        if len(page_links) > 0:
+                        if page_links:
                             for lnk in page_links:
                                 link_text = lnk.text.strip()
                                 if link_text.isdigit():
@@ -181,7 +181,7 @@ def search(self, search_params, age=0, ep_obj=None):  # pylint: disable=too-many
                             torrent_rows = html.findAll("tr", {"class": re.compile('torrent_[0-9]*')})
 
                             # Continue only if a Release is found
-                            if len(torrent_rows) == 0:
+                            if not torrent_rows:
                                 logger.log(u"Data returned from provider does not contain any torrents", logger.DEBUG)
                                 continue
 

sickbeard/providers/newpct.py

@@ -173,7 +173,7 @@ def download_result(self, result):
                     logger.log('Could not download {}'.format(url), logger.WARNING)
                     helpers.remove_file_failed(filename)
 
-        if len(urls):
+        if urls:
             logger.log('Failed to download any results', logger.WARNING)
 
         return False

sickbeard/providers/tntvillage.py

@@ -177,7 +177,7 @@ def _episodeQuality(torrent_rows):  # pylint: disable=too-many-return-statements
 
         img_all = (torrent_rows.find_all('td'))[1].find_all('img')
 
-        if len(img_all) > 0:
+        if img_all:
             for img_type in img_all:
                 try:
                     file_quality = file_quality + " " + img_type['src'].replace("style_images/mkportal-636/", "").replace(".gif", "").replace(".png", "")
@@ -197,7 +197,7 @@ def checkName(options, func):
         hdOptions = checkName(["720p"], any)
         fullHD = checkName(["1080p", "fullHD"], any)
 
-        if len(img_all) > 0:
+        if img_all:
             file_quality = (torrent_rows.find_all('td'))[1].get_text()
 
         webdl = checkName(["webdl", "webmux", "webrip", "dl-webmux", "web-dlmux", "webdl-mux", "web-dl", "webdlmux", "dlmux"], any)

sickbeard/providers/womble.py

@@ -65,7 +65,7 @@ def updateCache(self):
                 if ci:
                     cl.append(ci)
 
-        if len(cl) > 0:
+        if cl:
             cache_db_con = self._getDB()
             cache_db_con.mass_action(cl)
 

sickbeard/scene_numbering.py

@@ -531,7 +531,7 @@ def xem_refresh(indexer_id, indexer, force=False):
                          entry[sickbeard.indexerApi(indexer).config['xem_origin']]['episode']]
                     ])
 
-            if len(cl) > 0:
+            if cl:
                 main_db_con = db.DBConnection()
                 main_db_con.mass_action(cl)
 
@@ -649,6 +649,6 @@ def fix_xem_numbering(indexer_id, indexer):  # pylint:disable=too-many-locals, t
             ])
             update_scene_absolute_number = False
 
-    if len(cl) > 0:
+    if cl:
         main_db_con = db.DBConnection()
         main_db_con.mass_action(cl)

sickbeard/search.py

@@ -188,7 +188,7 @@ def snatchEpisode(result, endStatus=SNATCHED):  # pylint: disable=too-many-branc
         if data:
             notifiers.trakt_notifier.update_watchlist(result.show, data_episode=data, update="add")
 
-    if len(sql_l) > 0:
+    if sql_l:
         main_db_con = db.DBConnection()
         main_db_con.mass_action(sql_l)
 
@@ -540,7 +540,7 @@ def searchProviders(show, episodes, manualSearch=False, downCurQuality=False, ma
 
             didSearch = True
 
-            if len(searchResults):
+            if searchResults:
                 # make a list of all the results for this provider
                 for curEp in searchResults:
                     if curEp in foundResults: