Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better search width and align #194

Closed
wants to merge 2 commits into from
Closed

Conversation

medariox
Copy link
Contributor

After the change:
image

@pymedusa/contributors
Looks good?

Some downsides of left alignment:
image

@fernandog
Copy link
Contributor

@medariox
i vote por center alignment.
if you hide some columns it gets really ugly the left alignment

@medariox
Copy link
Contributor Author

I don't love the left alignment either. Both alignments have up- and downsides.

@labrys
Copy link
Contributor

labrys commented Mar 22, 2016

Personally i think centered looks terrible. I think it should be 3 sub columns within search so that icons always appear in same column. Also if forced search icons are hidden, why aren't selective also hidden? lastly i think that CC should be moved to the left side so it appears closer to the subtitles and so that the selective search arrow appears to point "off the page" instead of at the cc.

@fernandog
Copy link
Contributor

manual search/snatch shouldn't be hidden when status is skipped

@labrys
Copy link
Contributor

labrys commented Mar 22, 2016

imo if one method of file search is present the other should also be present.

@OmgImAlexis
Copy link
Collaborator

Why not just use display:none; or something similar and keep the icon there but just hide it from the user? That way they always stay in their spots and we don't need to add any extra columns.

@labrys
Copy link
Contributor

labrys commented Mar 22, 2016

@OmgImAlexis thats what i was thinking but my sleep-deprived mind couldnt quite dredge it out :)

@OmgImAlexis
Copy link
Collaborator

Also that icon may need to be changed as it is right now that looks like you're telling people that the search icon will do something called "CC" since it's pointing from one icon to the other.. 😞

@medariox
Copy link
Contributor Author

I like the idea of just hiding the image and also agree that we need a better "manual snatch" icon. This PR was aiming to be a quick fix for the current ugliness, further improvements will need a new PR. Going to merge the wider search column without left alignment for now, hope that's okay.

@medariox medariox closed this Mar 22, 2016
@fernandog fernandog deleted the better-search-style branch March 22, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants