-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better search width and align #194
Conversation
@medariox |
I don't love the left alignment either. Both alignments have up- and downsides. |
Personally i think centered looks terrible. I think it should be 3 sub columns within search so that icons always appear in same column. Also if forced search icons are hidden, why aren't selective also hidden? lastly i think that CC should be moved to the left side so it appears closer to the subtitles and so that the selective search arrow appears to point "off the page" instead of at the cc. |
manual search/snatch shouldn't be hidden when status is skipped |
imo if one method of file search is present the other should also be present. |
Why not just use |
@OmgImAlexis thats what i was thinking but my sleep-deprived mind couldnt quite dredge it out :) |
Also that icon may need to be changed as it is right now that looks like you're telling people that the search icon will do something called "CC" since it's pointing from one icon to the other.. 😞 |
I like the idea of just hiding the image and also agree that we need a better "manual snatch" icon. This PR was aiming to be a quick fix for the current ugliness, further improvements will need a new PR. Going to merge the wider search column without left alignment for now, hope that's okay. |
After the change:
@pymedusa/contributors
Looks good?
Some downsides of left alignment: