[Manual Search] Moved the creation of the searchResult to the searchQueue item. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p0psicles
commented
Apr 1, 2016
p0psicles
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read contribution guide
- Changed searchResult to snakecase.
- Removed unneeded params for snatchSelection() method.
- Changed mako to not send unneeded params. rowid is enough.
- Added check for getting the show_obj, chances are slim, but maybe a user leaves a snatchSelection window open, while deleting the show.
- Some pep8 changes.
- Added docstrings to webserve.py and search_queue.py methods.
| format(self.searchResult.name, | ||
| self.searchResult.seeders, self.searchResult.seeders, self.searchResult.provider.name)) | ||
| format(search_result.name, | ||
| search_result.seeders, search_result.seeders, search_result.provider.name)) |
There was a problem hiding this comment.
Second search_result.seeders should be search_result.leechers.
p0psicles
force-pushed
the
multiep_manualsearch
branch
from
9dd0926
to
a432ddd
Compare
|
Fixed from @medariox comments, and force pushed. |
* Changed searchResult to snakecase. * Removed unneeded params for snatchSelection() method. * Changed mako to not send unneeded params. rowid is enough. * Added check for getting the show_obj, chances are slim, but maybe a user leaves a snatchSelection window open, while deleting the show. * Some pep8 changes. * Added docstrings to webserve.py and search_queue.py methods.
p0psicles
force-pushed
the
multiep_manualsearch
branch
from
a432ddd
to
4f6d76b
Compare
|
Approved |
fernandog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.