[Manual Search] Remove unused variables #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandog
changed the title
fernandog
force-pushed
the
unused_variables
branch
6 times, most recently
from
03ebbe6
to
d3e07de
Compare
fernandog
force-pushed
the
manual-search
branch
2 times, most recently
from
3b22352
to
1195c5c
Compare
fernandog
force-pushed
the
unused_variables
branch
from
fb15b92
to
0ee4062
Compare
fernandog
force-pushed
the
unused_variables
branch
from
0ee4062
to
0d6012c
Compare
fernandog
force-pushed
the
unused_variables
branch
from
0d6012c
to
6b7d284
Compare
| @@ -154,9 +158,11 @@ def run(self): | |||
|
|
|||
| # give the CPU a break | |||
| time.sleep(common.cpu_presets[sickbeard.CPU_PRESET]) | |||
|
|
|||
| # What is this for ?! | |||
| generic_queue.QueueItem.finish(self) | |||
There was a problem hiding this comment.
@labrys what this does? and why only this thread have it ?
There was a problem hiding this comment.
I think i once added it to flag when A search was finished searching. But thats A long time ago.
fernandog
added a commit
that referenced
this pull request
Mar 3, 2016
[Manual Search] Remove unused variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables not needed in:
https://github.com/pyMedusa/SickRage/blob/manual-search/sickbeard/search.py#L94
@adaur @labrys @p0psicles can you please review with care this change?
correct way is checking with an IDE