Add Fan Art to snatchSelection.mako #806
Conversation
Thraxis
commented
Jul 22, 2016
•
Thraxis
commented
- Select Columns that can not be hidden
- Add sorting on select columns? (optional)
- Re-initialize the table every refresh or the search needs to be a proper ajax load of just table data (without it, while refreshing it shows the hidden columns) @p0psicles
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
61e769d
to
9b2366f
Compare
|
@Thraxis can you rebase please? columns that shouldn't be hidden: "release" and "snatch" |
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
9b2366f
to
0c95741
Compare
|
interesting fact... saveSort is enabled, but the query to load the search results over-rides it anyway. But there is a reset sort button now and it will reset the sort. |
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
0c95741
to
91f5d47
Compare
|
Working nice! @Thraxis columns width changed. can we use the old width? release column need to be a lot more wider. Seeds/peers dont need to be that wider. |
|
@Thraxis are you having this issue too? maybe because of the refreshing also when refresh is done, the sorting/filter and column selector are gone |
|
The refresh issue I had fixed in my testing branch but forgot to fix in the PR branch... widths should be good now with this fix as well |
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
27a07df
to
16e2685
Compare
|
@Thraxis do you know how to fix the last TODO (PR body) ? What about this codacy-bot issues? |
|
The change to use ajax for only refreshing the table will probably need to be future work. The current code will re-initialize the tablesorter as soon as it can. As for the codacy message, it's not an error so much as a "If you're doing this your CSS is getting too convoluted you should refactor it" |
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
2 times, most recently
from
20e80a8
to
5cb2585
Compare
|
Fixed a type-o that prevented the refresh in the last update... squashed to one commit and rebased to current development |
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
5cb2585
to
5d558ac
Compare
|
Coverage remained the same at 28.518% when pulling 5d558ac57bd3e4fabb15ac01b60bc8449527d61b on Thraxis:snatchSelection-Fan-Art into e078985 on pymedusa:develop. |
| @@ -98,7 +103,7 @@ | |||
| % endif | |||
| </ul> | |||
| </div><!-- #tags //--> | |||
| <div id="summary"> | |||
| <div id="summary" ${"class=\"summaryFanArt\"" if bool(sickbeard.FANART_BACKGROUND) else ""}> | |||
There was a problem hiding this comment.
Nope that should be all I have left to fix on this
* Adds FanArt and Banner to the snatchSelection.mako page. * Adds Column Filter and Search * Do not hide release or snatch columns * Do not sort on snatch * save sort, allow reset with button
Thraxis
force-pushed
the
snatchSelection-Fan-Art
branch
from
5d558ac
to
76e52b5
Compare
|
Approved |
|
@Thraxis thanks! If you want to re-work the AJAX feel free. |
|
@Thraxis are you going to work in the snatchSelection AJAX fix? |
