Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pymedusa/SickRage/issues/704 #817

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Fix pymedusa/SickRage/issues/704 #817

merged 2 commits into from
Sep 12, 2016

Conversation

fernandog
Copy link
Contributor

Fixes #704

@medariox medariox added this to the 0.1.3 milestone Jul 26, 2016
@fernandog fernandog added the Needs testing Requires testing to make sure it's working as intended label Jul 27, 2016
@fernandog
Copy link
Contributor Author

@ratoaq2 @Thraxis can any of you review this? Im concerned about DB tests in /tests folder

@fernandog fernandog modified the milestones: 0.1.3, 0.1.4 Jul 31, 2016
@fernandog
Copy link
Contributor Author

@pymedusa/developers can someone review/test this please?

@fernandog fernandog modified the milestones: 0.1.4, 0.1.5 Aug 16, 2016
@fernandog
Copy link
Contributor Author

@ratoaq2 can you review this please?

ratoaq2
ratoaq2 reviewed Sep 12, 2016
View reviewed changes
sickbeard/db.py
except Exception:
logger.log(u'DB error: {0!r}'.format(e), logger.ERROR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e is not defined here

@ratoaq2 ratoaq2 removed Needs review Needs testing Requires testing to make sure it's working as intended labels Sep 12, 2016
@ratoaq2
Copy link
Contributor

ratoaq2 commented Sep 12, 2016 •
edited by duramato
Loading

Approved

Approved with PullApprove

@ratoaq2 ratoaq2 mentioned this pull request Sep 12, 2016
Closed
@ratoaq2 ratoaq2 merged commit 9459e19 into develop Sep 12, 2016
@ratoaq2 ratoaq2 deleted the issue_704 branch September 12, 2016 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fernandog @ratoaq2 @medariox