Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Column Filter for blank item - Issue #842 #843

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Fix Column Filter for blank item - Issue #842 #843

merged 1 commit into from
Aug 1, 2016

Conversation

Thraxis
Copy link
Contributor

@Thraxis Thraxis commented Jul 31, 2016

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

Fixes Issues #842

Footer column span was 1 column wider then the actual columns used dues
to a column being hidden ( "Force Metadata Regen" )

@Thraxis
Fix Column Filter for blank item - Issue pymedusa#842
f415205 
Fixes Issues pymedusa#842

Footer column span was 1 column wider then the actual columns used dues
to a column being hidden ( "Force Metadata Regen" )
@Thraxis Thraxis added Bug Concluded Needs testing Requires testing to make sure it's working as intended labels Jul 31, 2016
@Thraxis Thraxis self-assigned this Jul 31, 2016
@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 28.805% when pulling f415205 on Thraxis:fix-842 into 6531126 on pymedusa:develop.

@fernandog
Copy link
Contributor

fernandog commented Aug 1, 2016 •
edited
Loading

Approved

Approved with PullApprove

@fernandog fernandog removed the Needs testing Requires testing to make sure it's working as intended label Aug 1, 2016
@fernandog fernandog merged commit 3f6b7fb into pymedusa:develop Aug 1, 2016
@fernandog fernandog added this to the 0.1.3 milestone Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Thraxis Thraxis

Labels
Bug Concluded
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thraxis @coveralls @fernandog