Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed foreground displayShowTable and summary opacity to 0.9, 0.8 i… #844

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Changed foreground displayShowTable and summary opacity to 0.9, 0.8 i… #844

merged 1 commit into from
Aug 2, 2016

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Aug 2, 2016 •
edited

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

The less transparant the background, the more it will trouble the foreground/content. In the examples below the background opacity is 0.4.

opacity 0.8:
image

opacity 0.9:
image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.805% when pulling d2fdac5 on feature/gui-fix-foreground-opacity into 2785afd on develop.

@fernandog
Copy link
Contributor

fernandog commented Aug 2, 2016 •
edited

Approved

Approved with PullApprove

@fernandog fernandog modified the milestone: 0.1.3 Aug 2, 2016
@p0psicles p0psicles merged commit 13ab40b into develop Aug 2, 2016
@medariox medariox deleted the feature/gui-fix-foreground-opacity branch August 4, 2016 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p0psicles @coveralls @fernandog