Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Page still broken since security patch. [dev branch] #11654

Closed
XxUnkn0wnxX opened this issue Mar 17, 2024 · 2 comments
Closed

History Page still broken since security patch. [dev branch] #11654

XxUnkn0wnxX opened this issue Mar 17, 2024 · 2 comments

Comments

@XxUnkn0wnxX
Copy link

Describe the bug
history page elements refuse to function since commit 14a7845
commit 1b0a21c broke it even further, history page won't even render now.

To Reproduce
Go to history page to marvel at its non-functionality

Expected behavior
to work like to work exactly as it did on commit: 70f9e90 before it broke.

Screenshots
Screen Shot 2024-03-18 at 3 49 33 am
Screen Shot 2024-03-18 at 3 49 26 am

Medusa (please complete the following information):

  • OS: macOS 11.7.10
  • Branch: develop
  • Commit: 1b0a21c
  • Python version: 3.11.6
  • Database version: 44.19

Debug logs (at least 50 lines):

2024-03-18 03:49:23 ERROR    TORNADO :: [1b0a21c] Uncaught exception in APIv2: AttributeError("'list' object has no attribute 'get'")
Request: GET /api/v2/history?page=1&limit=50&sort=[%7B%22field%22:%22actionDate%22,%22type%22:%22desc%22%7D] (127.0.0.1)
Traceback (most recent call last):
  File "/Users/ovidijus/Apps/Medusa/ext/tornado/web.py", line 1704, in _execute
    result = await result
             ^^^^^^^^^^^^
  File "/Users/ovidijus/Apps/Medusa/ext/tornado/gen.py", line 769, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ovidijus/Apps/Medusa/medusa/server/api/v2/base.py", line 64, in async_call
    content = yield IOLoop.current().run_in_executor(executor, prepared)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ovidijus/Apps/Medusa/ext/tornado/gen.py", line 762, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ovidijus/Apps/Medusa/medusa/server/api/v2/history.py", line 139, in get
    field = sort[0].get('field').lower()
            ^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'get'

Additional context
Full Logs:
Logs.zip

@XxUnkn0wnxX
Copy link
Author

XxUnkn0wnxX commented Mar 17, 2024

Commit: 9824610 partial Fixed, page renders, however most filters are still dead

Video demo of filters still dead: Video

@medariox
Copy link
Contributor

Fixed, please update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants