Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently there is no indication when a show has a per season exception #50

Closed
p0psicles opened this issue Feb 28, 2016 · 9 comments
Closed

Comments

@p0psicles
Copy link
Contributor

I'm going to implement an indication for shows which have a per season name exception.
Currently the only way to know there is any, is by tracking the debug logs, or digging in the db files.

I'm starting this issue to discuss the solution. If there are any other indicators that are missing, let me know!

Branch/Commit: SickRage master/dev
OS:
What you did: Opened the shows displayShow
What happened: No indication which (xem) per season exceptions are configured
What you expected: An indication
Logs:

Not needed

quick mockup:
image

@OmgImAlexis OmgImAlexis mentioned this issue Feb 28, 2016
14 tasks
@duramato
Copy link
Contributor

Now there are our scene exceptions per season too, perhaps support them too?

@OmgImAlexis
Copy link
Collaborator

Do we even have a way to add/edit per season exceptions apart from the JSON file? Might need to add that as well.

@duramato
Copy link
Contributor

@OmgImAlexis there is not, and agree

@p0psicles
Copy link
Contributor Author

@duramato are you talking about the "custom" field in the scene_exceptions table? If so, how do we support that besides that it's in the db?

@duramato
Copy link
Contributor

I dont know how it works behind the scenes, but i do know we support season exceptions from xem and our json
Perhaps check the commit that added it for a indept how it works

@p0psicles
Copy link
Contributor Author

Ok, got the xem exceptions working.
image

In case of fairy tail it's only showing the xem icon, for indexer_seasons 5,6,7

@p0psicles
Copy link
Contributor Author

Should I do the https://raw.githubusercontent.com/pymedusa/sickrage.github.io/master/scene_exceptions/scene_exceptions.json in one go? Or keep it for a separate PR?

@p0psicles
Copy link
Contributor Author

Never mind, got it like this:
image

Implementation is:
Check if xem_scene_exceptions mappings exsit, then use that, or else directly map them to the indexer seasons.

@p0psicles
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants