Error logged when circular buffer is empty

[rixius]

CoreViewerLink._update_viewer() causes MM to log lots of errors when the circular buffer is empty:

2024-03-14T11:12:27.488274 tid17768 [ERR,Core] Error occurred in device CMMCore::getLastImage: Circular buffer is empty.

Solution: I added

        if self._mmc.getRemainingImageCount() == 0:
            return

before the try-statement to suppress this.

(Note that the error is visible only when logging is enabled which I often do.)

[tlambert03]

hey @rixius, I'm happy to add this. And would be even happier if I could entice you to open a PR :) it's nice to have others looking at the codebase. Let me know if you don't have time and I can add it myself

[rixius]

Sure, I will. I assumed that I require permissions first to push code to the repository and create a PR.

[tlambert03]

I assumed that I require permissions first to push code to the repository and create a PR.

You would make the changes to a personal fork, and then create a PR. Happy to help get you started! Here are the steps you would need to follow:

1. Fork this repo. On the main page of this repo click "fork"
   
2. In your fork, create a new branch
3. In that new branch, make desired changes (you can either clone your fork to your local computer and then push them back to github, or you can directly edit the file in github
4. Once you've made the changes create a pull request

If any of that is confusing, or if you just want me to do it :) let me know!

[rixius]

I think I'm getting there, need another try...

[tlambert03]

no, no you did great! you can open it again. if you're worried about the tests failing, don't worry, i think those were not your issue

[tlambert03]

Thanks for the fix!