Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Live mode #34

Closed
ianhi opened this issue Aug 13, 2021 · 4 comments
Closed

Improve Live mode #34

ianhi opened this issue Aug 13, 2021 · 4 comments

Comments

@ianhi
Copy link
Contributor

ianhi commented Aug 13, 2021

Live mode is not optimal for example I experienced the below lagginess in live mode:

VID_20210812_172007796.mp4

It subsequently got much worse, not sure about reproducing as this could also be an issue with pymmcore-plus. I will try to try on a different machine soon, but wanted to open in case anyone else is having

@ianhi ianhi changed the title Live mode very laggy on Olympus IX83 on windows Improve Live mode Sep 1, 2021
@ianhi
Copy link
Contributor Author

ianhi commented Sep 1, 2021

I have tried this on a different computer and microscope and experienced the same. So I'm converting this to an issue to discuss ways to improve live mode performance. This is inspired by the complexity in micromanager's live mode which is implemented in this file:
https://github.com/micro-manager/micro-manager/blob/v2.0.0/mmstudio/src/main/java/org/micromanager/internal/SnapLiveManager.java

Among other things they:

  1. Use getLastImage to grab images (done in Use getLastImage for live mode #40)
  2. call startContinuousAcquisition(0) (vs ours with a finite value)
  3. adaptively update their image sampling and display rate: https://github.com/micro-manager/micro-manager/blob/4a5d51ea76f89eaa6e74d0d772822701661aa76a/mmstudio/src/main/java/org/micromanager/internal/SnapLiveManager.java#L309-L337

as a start I found that just implementing point 1 results in a significant performance boost but in time it will surely be helpful to take the lessons they learned and more closely mirror their live mode implementation.

@tlambert03
Copy link
Member

very helpful!

@tlambert03
Copy link
Member

can this be closed?

@tlambert03
Copy link
Member

I feel like lots of stuff has been improved here, and this issue is awaiting a response for over a year. So I'm going to close it. Please open new issue if there are remaining performance issues with live mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants