Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add uid to auto-generated name #198

Closed
sdrave opened this issue Dec 10, 2015 · 2 comments
Closed

do not add uid to auto-generated name #198

sdrave opened this issue Dec 10, 2015 · 2 comments
Milestone

Comments

@sdrave
Copy link
Member

@sdrave sdrave commented Dec 10, 2015

Right now, if not specified by the user, BasicInterface.name returns

type(self).__name__ + '_' + self.uid

However, I never had a use case where adding the uid was helpful.
On the other hand, adding the uid to the name makes the name depend on global state (the uid depends on the order of object creation and the specific pyMOR run), which already broke caching for me (f5bc852). I would propose to let the auto-generated name simply be the class name.

@sdrave sdrave added the question label Dec 10, 2015
@sdrave sdrave added this to the 0.4 milestone Dec 10, 2015
@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Dec 10, 2015

I agree. Never have had a use for this, either...

@sdrave
Copy link
Member Author

@sdrave sdrave commented Dec 10, 2015

Done in 5e33949.

@sdrave sdrave closed this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants