Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use f-strings throughout pyMOR #542

Closed
sdrave opened this issue Jan 21, 2019 · 3 comments
Closed

Use f-strings throughout pyMOR #542

sdrave opened this issue Jan 21, 2019 · 3 comments
Milestone
2019.2

Comments

@sdrave
Copy link
Member

sdrave commented Jan 21, 2019

At the dev meeting we decided to use the new f-string syntax in pyMOR.

Depends on #541.
@sdrave sdrave added this to the 2019.2 milestone Jan 21, 2019
@renefritze
Copy link
Member

There's probably automation for that, right?

@renefritze
Copy link
Member

There's probably automation for that, right?

Yes

Applied in 1e5632c
This might have left out some corner cases:

note: pyupgrade is intentionally timid and will not create an f-string if it would make the expression longer or if the substitution parameters are anything but simple names or dotted names (as this can decrease readability).

@renefritze renefritze mentioned this issue Jan 21, 2019
Merged
@sdrave
Copy link
Member Author

sdrave commented Jan 29, 2019

Implemented in #553.

@sdrave sdrave closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.2
Development

No branches or pull requests
2 participants
@renefritze @sdrave