page_rotation_reset does not return page to original rotation

[MaryiaTsalapava]

Description of the bug

Original document where pages were rotated is changed after running find_tables.
page_rotation_reset does not return page to original state.

How to reproduce the bug

Steps to reproduce:

• Find tables on page, that is rotated. Page rotation is 90 degrees in the example.
• Save current document
• Page has changed rotation in the original document

Expected behavior:

• Original document page is not changed after finding tables
• page_rotation_reset returns page to original state

Actual behavior:

• Original document page is rotated after finding tables
• page_rotation_reset does not return page to original state
• Looks like the rotated page is the result page from page_rotation_set0

import fitz
from fitz.table import find_tables


doc = fitz.Document("sample.pdf")
for page in doc.pages():
    for table in find_tables(page):
        for cell in table.cells:
            rect = fitz.Rect(*cell)
            highlight = page.add_rect_annot(rect)
            highlight.update()

doc.save("sample_output.pdf")

Sample document and document with changed page are attached:
sample.pdf
sample_output.pdf

PyMuPDF version

1.23.15

Operating system

Windows

Python version

3.9

[JorjMcKie]

Error identified and fixed developed. Will soon be published.
If you are interested in testing the solution, use this table.py in the branch that fixes it.

BTW: to mark table cells in a rotated page, you must multiply them with page.derotation_matrix, as shown here:

import fitz

doc = fitz.Document("sample.pdf")
page = doc[0]
tabs = page.find_tables()
tab = tabs[0]
for cell in tab.cells:
    cell = fitz.Rect(cell) * page.derotation_matrix
    page.draw_rect(cell, color=(1, 0, 0))

doc.ez_save("sample_output.pdf", pretty=True)

[MaryiaTsalapava]

Fix in table.py works, thank you!

[JorjMcKie]

Thank you very much for the confirmation!

[julian-smith-artifex-com]

Fixed in 1.23.17.