Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom attribute names don't work properly with Model.loads() #168

Closed
MarSoft opened this issue Oct 17, 2016 · 0 comments
Closed

Custom attribute names don't work properly with Model.loads() #168

MarSoft opened this issue Oct 17, 2016 · 0 comments
Labels
bug
Milestone
3.2.1

Comments

@MarSoft
Copy link

MarSoft commented Oct 17, 2016

In tests, custom attribute name (attr_name parameter) are tested only for hash key. But they won't work for other attributes, because Model._deserialize() looks up "custom" (pythonic) attr name and doesn't check attr.attr_name, in contrary to Model._serialize() which uses aliased_attrs() for lookup.
MarSoft added a commit to MarSoft/PynamoDB that referenced this issue Oct 17, 2016
@MarSoft
Model._deserialize: respect custom attr names
36d2c78 
this should also fix pynamodb#168
@MarSoft MarSoft mentioned this issue Oct 17, 2016
Closed
@jpinner-lyft jpinner-lyft added this to the 3.2.1 milestone Oct 24, 2017
jpinner-lyft added a commit that referenced this issue Oct 24, 2017
@jpinner-lyft
Model.loads() should deserialize using custom attribute names. Fixes #…
80ccf87 
…168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
2 participants
@MarSoft @jpinner-lyft