Deprecate json decode functionality in UnicodeStringSet
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmphilli
changed the title
UnicodeStringSet properly for numerics and booleans
danielhochman
approved these changes
Jun 9, 2017
pynamodb/attributes.py
Outdated
| This deserializes what we get from mongo back into a str | ||
| Serialization previously json encoded strings. This caused them to have | ||
| extra double quote (") characters. That no longer happens. | ||
| This method allows both types of serialized values to be read | ||
| :param value: |
There was a problem hiding this comment.
you could delete this docstring since it provides no value
jmphilli
changed the title
UnicodeStringSet properly for numerics and booleansUnicodeStringSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#249