Deserialize hash key during table loads. Fixes #143 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinner-lyft
force-pushed
the
table-load-deserialize-hash-key
branch
from
e4e709d
to
2d836d3
Compare
jmphilli
reviewed
Oct 24, 2017
| @@ -466,7 +466,7 @@ | |||
| 'N': '31' | |||
| }, | |||
| 'is_dude': { | |||
| 'N': '1' | |||
| 'BOOL': True | |||
There was a problem hiding this comment.
i think i may have been using this to test the old legacyboolattr, but if we remove that this is fine
There was a problem hiding this comment.
there are tests specific to legacy deserialization TestLegacyBooleanAttribute
jmphilli
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.