New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributes_to_get parameter to Model.scan #431
Conversation
Is there any plan to release this change? |
@garrettheel lgtm, agree? |
Ideally we'd add support for ProjectionExpressions, as AttributesToGet is now deprecated, but this is fine in the interim. Can you please rebase and also update the stubs in the |
d02872d
to
075b841
Compare
(Posting this time with the correct account...) Also, @garrettheel - agreed about ProjectionExpressions vs AttributesToGet, but I wasn't quite comfortable enough with the PynamoDB codebase to make that type of refactor yet. |
075b841
to
95e1792
Compare
Sorry for the delay @ButtaKnife. Would you mind resolving the conflicts and pinging me again so we can get this in? |
@garrettheel - Merged the latest! We've been using these changes against a fairly recent version of master in microservices at work and it's been good so far. Would be amazing to get the PR merged in here so we can stop using my fork. :) |
Thanks again! |
Add the attributes_to_get parameter to Model.scan to enable projection expressions on scan operations.