Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes_to_get parameter to Model.scan #431

Merged
merged 7 commits into from Oct 20, 2019

Conversation

ButtaKnife
Copy link
Contributor

Add the attributes_to_get parameter to Model.scan to enable projection expressions on scan operations.

@akashg90
Copy link

Is there any plan to release this change?

@ikonst
Copy link
Contributor

ikonst commented Feb 28, 2019

@garrettheel lgtm, agree?

@garrettheel
Copy link
Member

Ideally we'd add support for ProjectionExpressions, as AttributesToGet is now deprecated, but this is fine in the interim.

Can you please rebase and also update the stubs in the .pyi files (indexes.pyi and models.pyi)? [example]

.coveragerc Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@ButtaKnife
Copy link
Contributor Author

(Posting this time with the correct account...)
Oh hey, I had not seen the most recent replies on this PR since it's so ancient. I was just pulling in the latest changes, but I'll do a rebase and see about addressing the stubs. It would be great if this could be merged soon.

Also, @garrettheel - agreed about ProjectionExpressions vs AttributesToGet, but I wasn't quite comfortable enough with the PynamoDB codebase to make that type of refactor yet.

@garrettheel
Copy link
Member

Sorry for the delay @ButtaKnife. Would you mind resolving the conflicts and pinging me again so we can get this in?

@ButtaKnife
Copy link
Contributor Author

@garrettheel - Merged the latest! We've been using these changes against a fairly recent version of master in microservices at work and it's been good so far. Would be amazing to get the PR merged in here so we can stop using my fork. :)

@garrettheel garrettheel merged commit 47cc143 into pynamodb:master Oct 20, 2019
@garrettheel
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants