Fix Python 3 compatibility of PageIterator#key_names #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
im_self
doesn't exists anymore in python 3 (https://docs.python.org/2/reference/datamodel.html). So using six to fix this.Saw this happen multiple times in production. Sorry though I can't seem to redo it in unit test without messing with the internal state of the ResultIterator (e.g. by making
results_iter._index=1
so it is different from count after the iterator is fully consumed).Thanks for this package !