Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic = ["version"] to pyproject.toml #1772

Closed
jamestwebber opened this issue Sep 14, 2023 · 0 comments
Closed

Add dynamic = ["version"] to pyproject.toml #1772

jamestwebber opened this issue Sep 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jamestwebber
Copy link

This is a minor thing, but the pyproject.toml file generated by maturin init is not quite valid according to the schema (e.g. here). The [project] table should have an entry for version, or it should be a dynamic property.

Since maturin is automatically pulling the version from cargo.toml anyway, it's a simple fix to just add dynamic = ["version"] to the project table. This makes the toml follow the spec and the tool is already doing the right thing--no further config needed, as far as I can tell.

@jamestwebber jamestwebber added the enhancement New feature or request label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant