Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyodide-lock.json with absolute URLs #3943

Open
rth opened this issue Jun 22, 2023 · 0 comments · May be fixed by #3983
Open

pyodide-lock.json with absolute URLs #3943

rth opened this issue Jun 22, 2023 · 0 comments · May be fixed by #3983
Labels
enhancement New feature or request

Comments

@rth
Copy link
Member

rth commented Jun 22, 2023

Suppose we have the tooling to easily generate custom pyodide-lock.json once #3573 is addressed.

A common use case is that one would want to add some packages located on PyPI (or elsewhere) there so that they are loaded on import. Otherwise for instance, if you run existing notebooks in JupyterLite, some packages will be loaded on import, while others need to be pip installed, which is confusing for users, particularly when teaching.

In that scenario, one would want to directly put URLs to PyPI in pyodide-lock.json under the file_name field for some packages. However, I believe currently this would fail to properly work in Node here,

> nodePath.resolve("https://cdn.jsdelivr.net/pyodide/v0.23.3/full" || ".", "https://some-other-url")
'/home/rth/src/pyodide-utils/https:/cdn.jsdelivr.net/pyodide/v0.23.3/full/https:/some-other-url'

while it should be OK in the browser. In any case, we probably need more tests for this use case.

@rth rth added the enhancement New feature or request label Jun 22, 2023
@rth rth linked a pull request Jul 7, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant