PYOTP should respect RFC 6238 OTP tokens shorter than 6 digits should… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislyuk
added a commit
that referenced
this pull request
Aug 14, 2015
Pad tokens with zeros, per the example in RFC 6238
This was referenced Aug 22, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… be padded with 0
A fixed PR from the changes #7
According to RFC 6238, OTP tokens shorter
than 6 digits should be padded with 0 on the left in order to become 6 digits.
As a demonstration, the following code will produce a 5 digit token 41267 in
commit 5616a8d while the token
should really be 041267. This patch fixes the issue.