Add extended range support to TOTP.verify #19
Conversation
| @@ -16,15 +16,16 @@ def __init__(self, *args, **kwargs): | |||
| self.interval = kwargs.pop('interval', 30) | |||
| super(TOTP, self).__init__(*args, **kwargs) | |||
|
|
|||
| def at(self, for_time): | |||
| def at(self, for_time, increment=0): | |||
There was a problem hiding this comment.
Please rename increment to counter_offset.
| @@ -33,13 +34,20 @@ def now(self): | |||
| """ | |||
| return self.generate_otp(self.timecode(datetime.datetime.now())) | |||
|
|
|||
| def verify(self, otp, for_time=None): | |||
| def verify(self, otp, for_time=None, extra_range=0): | |||
There was a problem hiding this comment.
Please rename extra_range to valid_window.
|
Please add a test. You'll want a new test class in https://github.com/pyotp/pyotp/blob/master/test.py#L143. You can just look at Travis output if you don't want to figure out how to run tests locally. |
|
Thanks for opening the PR, this is a useful change. Once the test is in place to exercise these new options, I can merge it. |
| """ | ||
| if for_time is None: | ||
| for_time = datetime.datetime.now() | ||
|
|
||
| if valid_window: | ||
| for i in xrange(-valid_window, valid_window + 1): |
There was a problem hiding this comment.
Please use range() instead of xrange(). This library is Python 3 compatible.
|
I'd like to make the tests pass. They seem to time out at the moment. Do the tests pass for you locally? |
|
They pass for me locally in both 2.7.6 and 3.4.3. Update: I accidentally ran the master instead of the branch with the fix. On Tue, Oct 20, 2015 at 8:32 PM, Andrey Kislyuk notifications@github.com
|
|
There. All the tests pass and coverage is good. :) |
Add extended range support to TOTP.verify
|
Excellent, thanks! |
No description provided.