Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add otp operation about former #24

Closed
wants to merge 3 commits into from
Closed

Conversation

xiaochao
Copy link

Many websites verify current otp code and former otp code,which can make user input otp code when time end up soon.So,i add former function and verify_former function to make then operation more convenient.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.2%) to 87.705% when pulling 3c05d37 on xiaochao:master into 1d8b4c1 on pyotp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 90.476% when pulling b4fd2c5 on xiaochao:master into 1d8b4c1 on pyotp:master.

@kislyuk
Copy link
Member

kislyuk commented Apr 13, 2016

How is this different from the window kwarg to verify?

@kislyuk
Copy link
Member

kislyuk commented May 6, 2016

OK, I see now how it's different - you want the user to submit two subsequent TOTPs.

I think that's an antipattern. One should just have the user submit one TOTP, verify against a window of one or more timesteps, and adaptively adjust the clock skew correction if desired.

If you can point me to a discussion/opinion on this, I can be persuaded otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants