Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'canProgress' event for Introduction Screen #133

Closed
davoutuk opened this issue Jul 19, 2022 · 5 comments
Closed

Add new 'canProgress' event for Introduction Screen #133

davoutuk opened this issue Jul 19, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@davoutuk
Copy link

Can I suggest adding a new event to this otherwise excellent widget?

Add a new 'canProgress' event that can be used to check whether it is valid to progress to the next page, like:

canProgress: (page) {
// return true if movement to next page is permitted, or false if the progression is to be stopped.
}

@Pyozer
Copy link
Owner

Pyozer commented Jul 20, 2022

Hi, you can already freeze the scroll and/or hide progress dots by using :
freeze: true
isProgress: false

But yes, a canProgress event could be nice.
I will try to add it in next release, but not much time to maintain this project :/

@Pyozer Pyozer added the enhancement New feature or request label Jul 20, 2022
@timurturbil
Copy link
Contributor

@davoutuk I can add the event but couldn't get exactly what you want. Could you please explain more why do you need such event. Why do you need to check whether it is valid to progress to the next page?

@davoutuk
Copy link
Author

davoutuk commented Aug 12, 2022 via email

@timurturbil
Copy link
Contributor

@davoutuk I have opened a pull request for this feature. Can you check if it would meet your need?

@ghenry
Copy link
Collaborator

ghenry commented Nov 23, 2022

Hi all,

PR merged. Thanks!

Thanks,
Gavin.

@ghenry ghenry closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants