Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using minio official docker image #1008

Closed
cooperlees opened this issue Sep 10, 2021 · 2 comments · Fixed by #1087
Closed

Move to using minio official docker image #1008

cooperlees opened this issue Sep 10, 2021 · 2 comments · Fixed by #1087
Labels
enhancement New feature or request

Comments

@cooperlees
Copy link
Contributor

cooperlees commented Sep 10, 2021

Right now we use a fork to run minio for CI: https://github.com/pypa/bandersnatch/blob/main/.github/workflows/ci_ubuntu.yml#L21

Lets see if we can:

  • Pass arguments to use image as is
    • Maybe there is a way today I just didn't find
  • Add a second ENTRYPOINT script that starts an anonymous minio server (Merge to upstream repo)
  • If they won't accept, maybe create our own fork of the main and possibly automate keep the image up to date
@LeoQuote
Copy link
Contributor

Passing arguments is not feasible for now, There's no clean way to do it. https://github.community/t/job-service-command/16477

merge to minio image ? not so feasible too....

maybe we can try this https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions dockerfile steps. according to the document, we can just write a Dockerfile, with base minio/minio:latest and set the entrypoint and cmd.

cooperlees added a commit that referenced this issue Feb 13, 2022
…` official minio container

- Adding a run step to setup and start the official minio docker container
- This saves us from breaking if lazybit deletes their images or breaks etc.

Fixes #1008
@cooperlees
Copy link
Contributor Author

Sweet - #1087 works as the Github Actions ubuntu has docker installed and ready to be used like in that PR. So we can run the minio container via docker run in a step as it's backgrounded.

It's a bit of a race, but we don't start testing s3 first so we have a bit of time ... :)

cooperlees added a commit that referenced this issue Feb 13, 2022
… minio` (#1087)

* Move Ubuntu CI from using lazybit/minio:latest service to `docker run` official minio container

- Adding a run step to setup and start the official minio docker container
- This saves us from breaking if lazybit deletes their images or breaks etc.

Fixes #1008

* Fix run indent on setup minio step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants