Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor verify.py to use less memory #46

Closed
cooperlees opened this issue Jun 19, 2018 · 0 comments · Fixed by #48
Closed

Refactor verify.py to use less memory #46

cooperlees opened this issue Jun 19, 2018 · 0 comments · Fixed by #48
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@cooperlees
Copy link
Contributor

Refactor verify.py to iterate through the file system JSON files better and use less memory.

  • Potentially use a asyncio.Queue and have X (workers) consumers
    -- Store only filepath in the queue and not coros

At the moment loading all the coros into a list and uses asyncio.gather is using ~1.3gb of RAM. This is not cool nor scalable.
@cooperlees cooperlees added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jun 19, 2018
@tau3 tau3 mentioned this issue Jun 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix/46/verify-less-memory
1 participant
@cooperlees