Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal size error with 1.2.0 #760

Closed
santhonisz opened this issue Mar 28, 2024 · 2 comments · Fixed by #761
Closed

Terminal size error with 1.2.0 #760

santhonisz opened this issue Mar 28, 2024 · 2 comments · Fixed by #761

Comments

@santhonisz
Copy link

Hi there,

It appears that the changes added in #749 have the potential to break usage of build when the terminal size cannot be determined.

In our CI pipeline on Buildkite, we call python -m build -w on a python:3.8 Docker container. Since the release of build==1.2.0 this is failing with the following error:

image

The call to shutil.get_terminal_size().columns is evidently returning zero in this case and, as per the docs, when using Python < 3.11 the default fallback value will not be used.

Changed in version 3.11: The fallback values are also used if os.get_terminal_size() returns zeroes.

While it is possible to work around the issue in our pipeline, I think this scenario should be better handled by build.

@henryiii
Copy link
Contributor

I've yanked 1.2.0 and will try to get a 1.2.1 out soon.

@henryiii
Copy link
Contributor

1.2.1 is out. PyPI was blocking all uploads for a bit, but it's out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants