Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify pyc file calculation between two sdist implementations #569

Closed
wants to merge 1 commit into from
Closed

Unify pyc file calculation between two sdist implementations #569

wants to merge 1 commit into from

Conversation

nanonyme
Copy link
Contributor

Fixes #568

@nanonyme nanonyme marked this pull request as ready for review July 16, 2022 18:59
@layday
Copy link
Member

layday commented Jul 17, 2022 •
edited
Loading

This doesn't fix it for non-package folders of sdists built with flit-core - you'll want to take the check out from both flit_core/common.py and flit/sdist.py and register both patterns in flit-core's SdistBuilder as default excludes (or filter them out procedurally - whatever you/the maintainers prefer).

@nanonyme nanonyme marked this pull request as draft July 17, 2022 18:48
@takluyver
Copy link
Member

Thanks, but as @layday noted, this doesn't actually fix it. I'll close this and continue discussion on #568, or any new PRs that come from that.

@takluyver takluyver closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flit_core does not filter out Python bytecode when not operating on vcs
3 participants
@nanonyme @layday @takluyver