-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
get-pip needs some tests #18
Comments
Quoting myself from IRC:
Thoughts? |
We'd also need something on appveyor to cover the Windows one I mentioned. Not sure if appveyor also has cron jobs, but if so then yes. We'd need to work out how such a job would trigger a notification, too... An alternative would be to add a "regenerate and run get-pip" step to the pip test suite. But that may be complicated. |
Step 1 should probably simply be to write some scripts that test get-pip. Even if they have to be run manually in the first instance, we can work on integrating them into CI once we have them :-) |
I normally manually test them when I regenerate them, which is not great. |
https://www.appveyor.com/blog/2017/11/08/sheduled-builds-for-free-accounts/ https://www.appveyor.com/docs/build-configuration/#scheduled-builds |
Some further notes, on what's needed here.
For the record, just because I created the issue here didn't mean that I felt that CI on this repository was the answer - and the above comments explain why. My plan is as follows:
|
We can do (2) and run that specific test on daily basis with travis. |
(4) As an end-user I would like to see some proof that it's not broken right in my browser w/o needing to understand how to set up env locally and run those tests. |
So your (4) for me counts as a vote in favour of my (3).
Pip's tests run on every commit and PR. No need for daily runs as well. |
pip's tests also run everyday - a "cron" job on Travis. So, I feel we should have it here too. It's just a switch in the UI so, that's not anything major IMO. |
@pfmoore @pradyunsg also note that with Build Stages feature there's an if-clause support on stage/job definition levels, which allows to run completely different set of jobs/stages depending on whether it's normal build or it's cron/API/PR-triggered. |
#37 is something that tells me that we need to do this ASAP. :) |
I think this is resolved with #85. |
We need to be testing get-pip to ensure that pip changes don't break it. With the pip 10 release, the following issues weren't caught:
cacert.pem
.The text was updated successfully, but these errors were encountered: