Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set owner's read bit, in files written #140

Open
pmp-p opened this issue Sep 28, 2022 · 3 comments
Open

Always set owner's read bit, in files written #140

pmp-p opened this issue Sep 28, 2022 · 3 comments
Labels
component: destinations Related to WheelDestination and friends type: task Something that needs to be done that is not a bug or feature

Comments

@pmp-p
Copy link

pmp-p commented Sep 28, 2022 •
edited

on sys.platform=="emscripten" where oct(os.umask(0)) == 0o777 by default instead of 0o22
at

installer/src/installer/utils.py

Line 251 in 70ae05b

os.chmod(path, (0o777 & ~_current_umask() | 0o111))

the execute bit is set but the user read one is lost making it impossible to preload libraries (.so). ( maybe make_file_loadable ? that set at least u+rx )

emscripten-core/emscripten#17269
@pradyunsg
Copy link
Member

Hmm... I'm wondering if this should be fixed in emscripten or if we should have a workaround here.

@pmp-p Any specific preferences around this?

@pmp-p
Copy link
Author

pmp-p commented Oct 24, 2022 •
edited

well emscripten should be fixed, but installer should set both bits for file owner regardless of mask set for group/others.

@pradyunsg
Copy link
Member

Fair enough. A PR fixing this, with tests would be very welcome!

@pradyunsg pradyunsg added the type: task Something that needs to be done that is not a bug or feature label Oct 25, 2022
@pradyunsg pradyunsg changed the title make_file_executable may not set read bit Always set owner's read bit in files written Oct 25, 2022
@pradyunsg pradyunsg changed the title Always set owner's read bit in files written Always set owner's read bit, in files written Oct 25, 2022
@pradyunsg pradyunsg added the component: destinations Related to WheelDestination and friends label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: destinations Related to WheelDestination and friends type: task Something that needs to be done that is not a bug or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pradyunsg @pmp-p