Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipinfo Directories #71

Closed
Omegaice opened this issue Sep 13, 2021 · 2 comments · Fixed by #72
Closed

Zipinfo Directories #71

Omegaice opened this issue Sep 13, 2021 · 2 comments · Fixed by #72

Comments

@Omegaice
Copy link
Contributor

Whilst trying to solve a problem with installing torch using PDM I came across #69. After reading the code I realized that the change provided makes the error message more verbose but doesn't solve the issue for the torch package.

The problem seems to be that some whl files, when looping over self._zipfile.infolist() include the directories as well as the files which is what causes that function to fail because the RECORD file doesn't have information about directories. eg:

Torch (Directories as part of the list):

torch/
torch/_deploy.py
torch/functional.py
torch/onnx/
torch/onnx/symbolic_opset9.py
torch/onnx/symbolic_caffe2.py
torch/onnx/symbolic_helper.py
torch/onnx/symbolic_opset12.py
torch/onnx/symbolic_registry.py

Colorama (Files only):

colorama/__init__.py
colorama/ansi.py
colorama/ansitowin32.py
colorama/initialise.py
colorama/win32.py
colorama/winterm.py
colorama-0.4.4.dist-info/LICENSE.txt
colorama-0.4.4.dist-info/METADATA
colorama-0.4.4.dist-info/WHEEL
colorama-0.4.4.dist-info/top_level.txt
colorama-0.4.4.dist-info/RECORD
@pradyunsg
Copy link
Member

sigh

@carstencodes
Copy link

@pradyunsg Do you plan to release a python package with this fix soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants