Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging complains about invalid cpython version, ending with a + #748

Closed
doko42 opened this issue Nov 23, 2023 · 1 comment
Closed

packaging complains about invalid cpython version, ending with a + #748

doko42 opened this issue Nov 23, 2023 · 1 comment

Comments

@doko42
Copy link

doko42 commented Nov 23, 2023

when building cpython from the trunk, or one of the branches, the version is set to 3.12.0+, leading to errors (here in sunpy) like these:

sunpy/tests/helpers.py:49: in
if Version(python_version()) >= Version("3.10.0"):
/usr/lib/python3/dist-packages/packaging/version.py:200: in init
raise InvalidVersion(f"Invalid version: '{version}'")
E packaging.version.InvalidVersion: Invalid version: '3.12.0+'
_ ERROR collecting .pybuild/cpython3_3.12_sunpy/build/sunpy/io/special/asdf/tests/test_coordinate_frames.py

These are just temporary issues, however it makes it a bit inconvenient to use a non-release build. Possible solutions:

  • Patch out the "+" from the branch build, such that it still identifies as 3.12.0. However then nothing (except for a ChangeLog) can be seen to differentiate a release build from a branch build.
  • Let packaging recognize the "+" at the end as a valid version string
  • Let cpython use a version which packaging understands (e.g. 3.12.0.1)
@pradyunsg
Copy link
Member

Duplicate of #678

@pradyunsg pradyunsg marked this as a duplicate of #678 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants