Use shell=False when "run" if possible on Windows #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a "where" on the command; if it is found, prevent the intermediate COMSPEC and use CreateProcess directly. Only use shell=True if the command is not an executable. This prevents some unexpected behaviour caused by the intermediate shell process.
|
Need #2386 first for this to work. |
|
Hm yeah this makes sense to me. |
Signed-off-by: Dan Ryan <dan@danryan.co>
|
Tested this out locally on windows and it seems good |
techalchemy
added
Type: Enhancement 💡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a
whereon the command; if it is found, prevent the intermediateCOMSPECand useCreateProcessdirectly. Only useshell=Trueif the command is not an executable.This prevents some unexpected behaviour caused by the intermediate shell process.