Ensure environs are strings on Python 2 + Windows #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
reviewed
Jun 19, 2018
pipenv/vendor/dotenv/main.py
Outdated
| # With Python2 on Windows, force environment variables to str to | ||
| # avoid "TypeError: environment can only contain strings" in | ||
| # Python's subprocess module. | ||
| if sys.version_info.major < 3 and sys.platform == 'win32': |
There was a problem hiding this comment.
we can use pipenv.utils.fs_str()
uranusjr
force-pushed
the
python2-dotenv-subprocess-conflict
branch
from
8f1313c
to
1341b28
Compare
techalchemy
reviewed
Jun 22, 2018
| # system strings to avoid "TypeError: environment can only contain | ||
| # strings" in Python's subprocess module. | ||
| if sys.version_info.major < 3 and sys.platform == 'win32': | ||
| from pipenv.utils import fs_str |
There was a problem hiding this comment.
Is there any reason not to just do this all the time? Why not just always use fs_str here?
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
python2-dotenv-subprocess-conflict
branch
from
1341b28
to
154f13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch based on theskumar/python-dotenv#101 by @greyli.