Allow check to ignore packages

[erinxocon]

and append it to the call to safety

[erinxocon]

this is a fix for #2407, we were collecting the arguments passed but not actually passing them to safety

[erinxocon]

needs test

[jarshwah]

Using ignore here is confusing, because there could be other args. Consider using safety_args instead?

[erinxocon]

@techalchemy?

[erinxocon]

@jarshwah I renamed the parameter option to pipenv check --safety_ignore [package_name]. Is that ok?

[jarshwah]

@erinxocon it won't allow callers to ignore multiple issues. Can you make safety_ignore args a list, and then explode to multiple -i args internally?

Something like this perhaps?

'-i '.join(vid for vid in safety_ignore_list)

See: https://github.com/pyupio/safety#--ignore--i

[erinxocon]

ahh ok, I wasn't familiar with the api for safety. Hold please

[jarshwah]

No problem!

For what it's worth, I don't think (m)any of the other CLI options to safety would be useful from pipenv so it might be worth creating a new option directly in the check cli function. That would probably make it easier to implement too with http://click.pocoo.org/5/options/#multiple-options

[erinxocon]

Ok @jarshwah, I've updated the syntax to pipenv check --safety-ignore [package1] [package2] [package3].... I don't know if we need to make a new click option for this. I'll pin @kennethreitz regarding an api change like that.

EDIT: I eat my words, adding an option was exactly what I ended up doing haha, thanks @jarshwah

[jarshwah]

Turn around time on this one was super fast, thanks so much!

[techalchemy]

(I removed a print statement)

Does it make sense to change this to --ignore if it's going directly on the safety API? Sorry for the back and forth, I just didn't think through the implementation before I suggested the change :(

[techalchemy]

Swapped it over to --ignore and added some tests + news entry, going to merge this before release

[erinxocon]

thanks @techalchemy, I should have created the news. Sorry for leaving print in there, I was debugging.