Use --pypi-mirror during virtualenv initialization #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
reviewed
Jun 28, 2018
pipenv/core.py
Outdated
| @@ -933,7 +934,8 @@ def do_create_virtualenv(python=None, site_packages=False): | |||
| # Actually create the virtualenv. | |||
| with spinner(): | |||
| try: | |||
| c = delegator.run(cmd, block=False, timeout=PIPENV_TIMEOUT) | |||
| pip_config = {'PIP_INDEX_URL': pypi_mirror} if pypi_mirror else {} | |||
There was a problem hiding this comment.
from .utils import fs_str
pip_config = {'PIP_INDEX_URL': fs_str(pypi_mirror)} if pypi_mirror else {}There was a problem hiding this comment.
This has been revised
Adds support for the --pypi-mirror parameter for all operations which may result in a virtualenv initialization. When a virtualenv is initialized, pip attempts to download several dependencies from PyPI. If PyPI is unavailable, virtualenv silently uses local packages instead, which is acceptable in most cases. However, in some environments connection attempts to PyPI will stall rather than fail, causing a pipenv timeout. By using the mirror specified by --pypi-mirror, we can ensure virtualenv will attempt to download dependencies from an accessible mirror instead of PyPI. - Fixes pypa#2455
JacobHenner
force-pushed
the
bugfix/2455-virtualenv-pypi-mirror
branch
from
f050a5a
to
0503c20
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the --pypi-mirror parameter for all operations which
may result in a virtualenv initialization.
When a virtualenv is initialized, pip attempts to download several
dependencies from PyPI. If PyPI is unavailable, virtualenv silently uses
local packages instead, which is acceptable in most cases. However, in
some environments connection attempts to PyPI will stall rather than
fail, causing a pipenv timeout. By using the mirror specified by
--pypi-mirror, we can ensure virtualenv will attempt to download
dependencies from an accessible mirror instead of PyPI.