Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use COMSPEC for shell detection fallback #2651

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Conversation

uranusjr
Copy link
Member

The subshell logic now considers:

  • PIPENV_SHELL
  • Auto detection
  • SHELL (should very likely work for POSIX)
  • PYENV_SHELL
  • COMSPEC (should always work for Windows)

This should be able to close sarugaku/shellingham#9 in the sense of not raising an exception.

The subshell logic now considers:

* PIPENV_SHELL
* Auto detection
* SHELL (should very likely work for POSIX)
* PYENV_SHELL
* COMSPEC (should always work for Windows)
@techalchemy
Copy link
Member

Seems good, there was no alternative for far manager or whatever that was?

@uranusjr
Copy link
Member Author

Far Manager can be detected, but I don’t know it well enough and don’t know if it is even a good idea to spawn it (it’s more like a CLI file manager than a shell, complete with menus and things, similar to old DOS applications). This looks like a reasonable thing to do anyway (considering we already detect SHELL and even PYENV_SHELL), and does kind of resolve the problem.

@uranusjr uranusjr added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Jul 30, 2018
@uranusjr uranusjr merged commit 7223240 into master Jul 30, 2018
@uranusjr uranusjr deleted the shell-fallback-improvement branch July 30, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not detect shell when called from within Far Manager
2 participants