Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing private repo with git+git is not working at 2018.7.1 version #2704

Closed
akefeli opened this issue Aug 3, 2018 · 5 comments
Closed
Labels
Type: Duplicate This issue is a duplicate of an already-existing issue.

Comments

@akefeli
Copy link

akefeli commented Aug 3, 2018

This works with older version:
pipenv version: 11.10.1
pipenv install -e git+git@github.com:some/repo.git#egg=foo\&subdirectory=sub

Running same command with version: 2018.7.1.
First part succeeds, then second part fails.

Installing ...
Obtaining foo from git+git@github.com:CloudVLab/fusion.git#egg=Fusion&subdirectory=python
...
Successfully installed foo

Adding -e git+git@github.com:... to Pipfile's [packages]...

Pipfile.lock (a34c46) out of date, updating to (0c0917)...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
...
Command "git clone -q ssh://git@github.com:some/repo.git /tmp/tmptsmueli7source/foo" failed with error code 128 in None
...

Pipenv should either do(both commands are exactly same AFAIK):
git clone git@github.com:some/repo.git
or
git clone ssh://git@github.com/some/repo.git
notice the : vs /

instead it is doing:
ssh://git@github.com:some/repo.git
which obviously not working.

As a workaround I had to do:
pipenv install -e git+ssh://git@github.com/some/repo.git

@techalchemy
Copy link
Member

This is resolved in what will be the next release (I'd link to the issues but we fixed it some time ago)

Have been slammed on our end lately, but should be able to get the release out shortly -- sorry for the issue!

@techalchemy techalchemy added the Type: Duplicate This issue is a duplicate of an already-existing issue. label Aug 4, 2018
@coltonbh
Copy link

@techalchemy This issue appears to not be resolved. Spent a long time today tracking down that pesky ":" -> "/" required change. Any change this issue will get fixed? Thanks :)

@dsummersl
Copy link

I'm also running into this issue today :'(

@coltonbh
Copy link

@dsummersl did you make the : -> / transition in the ssh path of the repo you are trying to install?

@dsummersl
Copy link

Nope, I tried it. Works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Duplicate This issue is a duplicate of an already-existing issue.
Projects
None yet
Development

No branches or pull requests

4 participants